Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HeapBufferType to represent _ddata in Dyno #26065

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Add HeapBufferType to represent _ddata in Dyno #26065

wants to merge 11 commits into from

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented Oct 9, 2024 •
edited
Loading

Add a new HeapBufferType to represent _ddata in Dyno.

  • Supports .eltType and this on _ddata.
  • Adds new PtrType as parent to both this and CPtrType, since they're very similar.
  • Includes testing for HeapBufferType analogous to the testing on CPtrType.

Resolves https://github.com/Cray/chapel-private/issues/6777, https://github.com/Cray/chapel-private/issues/6769 and https://github.com/Cray/chapel-private/issues/6768.

[reviewer info placeholder]

Testing:

  • dyno tests
  • paratest

@riftEmber
Also test without stdlib
b7476be 
Signed-off-by: Anna Rift <[email protected]>
@riftEmber riftEmber marked this pull request as ready for review October 10, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@riftEmber